Skip to content

gh-146261: Fix bug in _Py_uop_sym_set_func_version #146291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 2 commits into from
Mar 22, 2026
+1 −1
Merged

gh-146261: Fix bug in _Py_uop_sym_set_func_version #146291

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b81201f
Restore Optimization and revert tests
Sacul0457 Mar 22, 2026
8a08593
revert and reduce change
Sacul0457 Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Python/optimizer_symbols.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ _Py_uop_sym_set_func_version(JitOptContext *ctx, JitOptRef ref, uint32_t version
case JIT_SYM_PREDICATE_TAG:
case JIT_SYM_TRUTHINESS_TAG:
sym_set_bottom(ctx, sym);
return true;
return false;
Copy link
Member

@Fidget-Spinner Fidget-Spinner Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, can you just reduce the PR to just this line? I'm really sorry for taking up your time on this Sacul.

After staring at this more, I realised the original function watcher idea works, but needs a lot more work. I think this might be too complicated for a contributor to take, so I'll take over. Thanks for opening the issue again and for spotting this mistake of mine!

Copy link
Contributor Author

@Sacul0457 Sacul0457 Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, glad to be able to help where I can :)

case JIT_SYM_RECORDED_VALUE_TAG: {
PyObject *val = sym->recorded_value.value;
if (Py_TYPE(val) != &PyFunction_Type ||
Expand Down
Loading