Skip to content

gh-144540: Eliminate _MAKE_HEAP_FUNCTION for owned references #146320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Sacul0457 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Draft

gh-144540: Eliminate _MAKE_HEAP_FUNCTION for owned references #146320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Lib/test/test_capi/test_opt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1352,7 +1352,7 @@ def testfunc(n):
self.assertNotIn("_MAKE_HEAP_SAFE", uops)
self.assertIn("_YIELD_VALUE", uops)

def test_make_heap_safe_not_optimized_for_owned(self):
def test_make_heap_safe_optimized_owned(self):
def returns_owned(x):
return x + 1
def testfunc(n):
Expand All @@ -1364,7 +1364,7 @@ def testfunc(n):
self.assertEqual(res, TIER2_THRESHOLD)
self.assertIsNotNone(ex)
uops = get_opnames(ex)
self.assertIn("_MAKE_HEAP_SAFE", uops)
self.assertNotIn("_MAKE_HEAP_SAFE", uops)
self.assertIn("_RETURN_VALUE", uops)

def test_for_iter(self):
Expand Down
2 changes: 1 addition & 1 deletion Python/optimizer_bytecodes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ dummy_func(void) {

op(_MAKE_HEAP_SAFE, (value -- value)) {
// eliminate _MAKE_HEAP_SAFE when we *know* the value is immortal
if (sym_is_immortal(PyJitRef_Unwrap(value))) {
if (sym_is_immortal(PyJitRef_Unwrap(value)) || !PyJitRef_IsBorrowed(value)) {
ADD_OP(_NOP, 0, 0);
}
value = PyJitRef_StripBorrowInfo(value);
Expand Down
2 changes: 1 addition & 1 deletion Python/optimizer_cases.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading