Skip to content

gh-145866: Convert DICT_MERGE to leave its inputs on the stack to be cleaned up by _POP_TOP#146329

Open
NekoAsakura wants to merge 1 commit intopython:mainfrom
NekoAsakura:dict-merge-pop-top
Open

gh-145866: Convert DICT_MERGE to leave its inputs on the stack to be cleaned up by _POP_TOP#146329
NekoAsakura wants to merge 1 commit intopython:mainfrom
NekoAsakura:dict-merge-pop-top

Conversation

@NekoAsakura
Copy link

@NekoAsakura NekoAsakura commented Mar 23, 2026

@bedevere-app
Copy link

bedevere-app bot commented Mar 23, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented Mar 23, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, and welcome to CPython :)!

@Fidget-Spinner
Copy link
Member

@NekoAsakura sorry, for CPython we don't force push, as all commits are squash-merged. So just do normal commits and I'll squash it at the end. Thank you!

@NekoAsakura
Copy link
Author

Thanks for your contribution, and welcome to CPython :)!

Thanks for the review and the warm welcome(^^)! Changes applied.

Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants