bpo-39877: Fix PyEval_RestoreThread() for daemon threads#18811
Merged
vstinner merged 1 commit intopython:masterfrom Mar 8, 2020
vstinner:daemon_thread_runtime2
Merged
bpo-39877: Fix PyEval_RestoreThread() for daemon threads#18811vstinner merged 1 commit intopython:masterfrom vstinner:daemon_thread_runtime2
vstinner merged 1 commit intopython:masterfrom
vstinner:daemon_thread_runtime2
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
variable, rather than using tstate->interp->runtime since tstate
can be a dangling pointer after Py_Finalize() has been called.
take_gil(). There is no need to protect the call with the GIL.
at runtime. Check tstate earlier. take_gil() is now responsible to
check that tstate is not NULL.
Cleanup:
done inside take_gil().
PyEval_RestoreThread() and _PyEval_EvalFrameDefault() now check if
tstate is valid with the new is_tstate_valid() function which uses
_PyMem_IsPtrFreed().
https://bugs.python.org/issue39877