Skip to content

Expand renderIntoDocument migration guidance#8371

Open
rinadavidyuk826-sudo wants to merge 1 commit intoreactjs:mainfrom
rinadavidyuk826-sudo:docs-expand-renderintodocument-guidance
Open

Expand renderIntoDocument migration guidance#8371
rinadavidyuk826-sudo wants to merge 1 commit intoreactjs:mainfrom
rinadavidyuk826-sudo:docs-expand-renderintodocument-guidance

Conversation

@rinadavidyuk826-sudo
Copy link

Closes #28

Summary

  • explain why renderIntoDocument was awkward to clean up in tests
  • point readers to render, unmount, and cleanup in React Testing Library
  • keep the migration guidance scoped to the existing warning page

@meta-cla
Copy link

meta-cla bot commented Mar 22, 2026

Hi @rinadavidyuk826-sudo!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@github-actions
Copy link

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@rinadavidyuk826-sudo
Copy link
Author

I completed the CLA signing flow and got the confirmation that future pull requests from this GitHub account should now be accepted.

Could you please re-check the CLA status for this PR? Thanks.

@meta-cla
Copy link

meta-cla bot commented Mar 22, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed label Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve/create documentation for ReactTestUtils.renderIntoDocument()

1 participant