Support for get_keyword_source#28
Merged
aaltat merged 7 commits intorobotframework:masterfrom Mar 28, 2020
Merged
Conversation
64855f3 to
73c6cf4
Compare
pekkaklarck
approved these changes
Mar 28, 2020
pekkaklarck
reviewed
Mar 29, 2020
| for line in source: | ||
| if line.strip().startswith('def'): | ||
| return line_number | ||
| line_number += 1 |
Member
There was a problem hiding this comment.
Hmm, this doesn't work correctly if someone has a library like this:
class LambdaLib:
kw = lambda self: 42Above is obviously rather strange but from RF point of view it's valid. I see two solutions:
- Return the original
line_numberifdefline isn't found at all. - Just return whatever
getsourcelinesreturns.
Member
There was a problem hiding this comment.
A bigger problem is that decorators returning different function than the original aren't supported correctly. Same issue on Robot side that the moment:
robotframework/robotframework#3516 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26