Skip to content

Drop support for RF 3.0.2 #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaltat merged 1 commit into from
Apr 12, 2020
Merged

Drop support for RF 3.0.2 #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/robotlibcore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ def get_keyword_names(self):


class DynamicCore(HybridCore):
__get_keyword_tags_supported = False # get_keyword_tags is new in RF 3.0.2

def run_keyword(self, name, args, kwargs=None):
return self.keywords[name](*args, **(kwargs or {}))
Expand All @@ -106,7 +105,6 @@ def get_keyword_arguments(self, name):
return spec.get_arguments()

def get_keyword_tags(self, name):
self.__get_keyword_tags_supported = True
return self.keywords[name].robot_tags

def get_keyword_documentation(self, name):
Expand All @@ -116,7 +114,7 @@ def get_keyword_documentation(self, name):
return inspect.getdoc(self.__init__) or ''
kw = self.keywords[name]
doc = inspect.getdoc(kw) or ''
if kw.robot_tags and not self.__get_keyword_tags_supported:
if kw.robot_tags:
tags = 'Tags: {}'.format(', '.join(kw.robot_tags))
doc = '{}\n\n{}'.format(doc, tags) if doc else tags
return doc
Expand Down
6 changes: 2 additions & 4 deletions utest/test_robotlibcore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ def test_dir():
'_DynamicCore__get_keyword',
'_DynamicCore__get_keyword_line',
'_DynamicCore__get_keyword_path',
'_DynamicCore__get_keyword_tags_supported',
'_DynamicCore__get_typing_hints',
'_DynamicCore__join_defaults_with_types',
'_HybridCore__get_members',
Expand Down Expand Up @@ -77,7 +76,6 @@ def test_dir():
'_DynamicCore__get_keyword',
'_DynamicCore__get_keyword_line',
'_DynamicCore__get_keyword_path',
'_DynamicCore__get_keyword_tags_supported',
'_DynamicCore__join_defaults_with_types',
'get_keyword_arguments',
'get_keyword_documentation',
Expand Down Expand Up @@ -290,8 +288,8 @@ def test_get_keyword_tags():
doc = lib.get_keyword_documentation
assert tags('tags') == ['tag', 'another tag']
assert tags('doc_and_tags') == ['tag']
assert doc('tags') == ''
assert doc('doc_and_tags') == 'I got doc!'
assert doc('tags') == 'Tags: tag, another tag'
assert doc('doc_and_tags').splitlines() == ['I got doc!', '', 'Tags: tag']


def test_library_cannot_be_class():
Expand Down