Skip to content

fix: emcn component library design engineering polish#3672

Open
adithyaakrishna wants to merge 15 commits intosimstudioai:stagingfrom
adithyaakrishna:feat/emcn
Open

fix: emcn component library design engineering polish#3672
adithyaakrishna wants to merge 15 commits intosimstudioai:stagingfrom
adithyaakrishna:feat/emcn

Conversation

@adithyaakrishna
Copy link
Contributor

Summary

Comprehensive polish of the emcn compos library along with addressing a11y issues and design token consistency

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Other: Components Polish

Testing

  • Visual regression: Button variants (tertiary no longer uses !important, base class restructured), toast auto-dismiss now 5s default, dropdown menu wider
  • Touch devices: Verify hover states no longer stick on tap
  • Keyboard navigation: Tab through Input, Textarea, Slider, Switch all now show visible focus indicators
  • Reduced motion: Toggle prefer reduced motion (macos setting), all animations should be disabled

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@cursor
Copy link

cursor bot commented Mar 19, 2026

PR Summary

Medium Risk
Medium risk because it introduces new global CSS variables and replaces many hard-coded colors/sizes across auth, landing, blog, and changelog UIs; regressions in contrast/hover states or token availability could impact multiple pages. Minor behavioral tweaks (signup validation reveal animation, marquee pause-on-hover, chat customization default color) could also change user-facing flows.

Overview
Standardizes marketing/auth UI styling around new CSS tokens. Replaces many hard-coded hex colors and pixel-based Tailwind classes across landing, blog, changelog, and auth pages with --landing-* variables and normalized spacing/typography utilities.

Adds shared global design primitives. Introduces a global z-index scale, shadow presets, and theme-aware scrollbar colors in globals.css, and updates branded button CSS variables (--brand*) plus semantic colors (--success, --error, --caution).

Small UX/behavioral polish. Improves signup form validation message presentation (animated expand/collapse), refines enterprise marquee animation to pause on hover, tweaks default chat primaryColor fallback, and removes restrictive viewport scaling settings in apps/docs.

Written by Cursor Bugbot for commit 039fe37. This will update automatically on new commits. Configure here.

@vercel
Copy link

vercel bot commented Mar 19, 2026

@adithyaakrishna is attempting to deploy a commit to the Sim Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Mar 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Mar 20, 2026 5:50pm

Request Review

@icecrasher321 icecrasher321 self-assigned this Mar 20, 2026
@icecrasher321
Copy link
Collaborator

@adithyaakrishna just ping me when this is ready for review. We'll go through this together.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@adithyaakrishna
Copy link
Contributor Author

@icecrasher321 this is ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants