-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat(email): add SMTP support for self-hosted platform emails #3696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
f907d40
98ae184
196c32d
53e0399
5b6a056
715025a
304d0f6
94f94b3
1911264
965ae39
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,40 @@ | ||||||||
| name: Build and Push to ECR | ||||||||
|
|
||||||||
| on: | ||||||||
| push: | ||||||||
| branches: [main] | ||||||||
| workflow_dispatch: | ||||||||
|
|
||||||||
| env: | ||||||||
| AWS_REGION: us-west-2 | ||||||||
| ECR_REGISTRY: 310455165573.dkr.ecr.us-west-2.amazonaws.com | ||||||||
| ECR_REPOSITORY: sim-app | ||||||||
|
|
||||||||
| jobs: | ||||||||
| build: | ||||||||
| runs-on: ubuntu-latest | ||||||||
| steps: | ||||||||
| - uses: actions/checkout@v4 | ||||||||
|
Comment on lines
+16
to
+17
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The ECR registry URL
Suggested change
|
||||||||
|
|
||||||||
| - name: Configure AWS credentials | ||||||||
| uses: aws-actions/configure-aws-credentials@v4 | ||||||||
| with: | ||||||||
| aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} | ||||||||
| aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||||||||
| aws-region: ${{ env.AWS_REGION }} | ||||||||
|
|
||||||||
| - name: Login to Amazon ECR | ||||||||
| uses: aws-actions/amazon-ecr-login@v2 | ||||||||
|
|
||||||||
| - name: Set up Docker Buildx | ||||||||
| uses: docker/setup-buildx-action@v3 | ||||||||
|
|
||||||||
| - name: Build and push | ||||||||
| uses: docker/build-push-action@v6 | ||||||||
| with: | ||||||||
| context: . | ||||||||
| file: docker/app.Dockerfile | ||||||||
| push: true | ||||||||
| tags: ${{ env.ECR_REGISTRY }}/${{ env.ECR_REPOSITORY }}:latest | ||||||||
| cache-from: type=gha | ||||||||
| cache-to: type=gha,mode=max | ||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ECR workflow exposes AWS account ID in public repo
Low Severity
The new
build-ecr.ymlworkflow hardcodes the AWS account ID (310455165573) and ECR repository details directly in the file. This is unrelated to the SMTP feature described in the PR and exposes internal infrastructure details in a public repository. It also runs on every push tomain, building and pushing a:latesttag without a commit SHA, which means image provenance is lost.