fix(autolayout): edits coalesced for same request diffs#3724
fix(autolayout): edits coalesced for same request diffs#3724icecrasher321 merged 4 commits intostagingfrom
Conversation
PR SummaryMedium Risk Overview Extends Adds focused Vitest coverage for the new change-set and shift behavior, including hyphenated handles/ids and cross-scope edge changes. Written by Cursor Bugbot for commit adc5cee. Configure here. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryThis PR refactors how autolayout determines which blocks need repositioning after a copilot edit, extracting the ad-hoc detection logic that was duplicated in
Confidence Score: 4/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[getTargetedLayoutImpact] --> B{New block?}
B -- Yes --> C[Add to layoutBlockIds]
B -- No --> D{Parent changed + pos 0,0?}
D -- Yes --> C
D -- No --> E[skip]
A --> F[getBlocksWithInvalidPositions - all after blocks]
F -- invalid or 0,0 --> C
A --> G[getAddedLayoutScopedEdges]
G -- no new edges --> H[Return: layoutBlockIds + shiftSourceBlockIds empty]
G -- new edges --> I{Target gained first incoming edge?}
I -- Yes --> C
I -- No --> J[Add source to shiftSourceBlockIds]
C --> K[applyTargetedLayout]
J --> K
K --> L{needsLayout more than 0?}
L -- Yes --> M[computeLayoutPositions + apply offsets to needsLayout blocks]
L -- No --> N[skip layout computation]
M --> O[shiftDownstreamFrozenBlocks BFS from activeShiftSourceSet]
N --> O
O --> P{needsLayout more than 0?}
P -- Yes --> Q[resolveVerticalOverlapsWithFrozen]
P -- No --> R[Done]
Q --> R
Reviews (1): Last reviewed commit: "fix(autolayout): edits coalesced for sam..." | Re-trigger Greptile |
|
bugbot run |
|
bugbot run |
Summary
Need to identify targetted autlayout targets more intelligently.
Type of Change
Testing
Tested manually
Checklist