Skip to content

fix(quiver): build fail#3730

Merged
Sg312 merged 5 commits intostagingfrom
fix/mothership-test
Mar 24, 2026
Merged

fix(quiver): build fail#3730
Sg312 merged 5 commits intostagingfrom
fix/mothership-test

Conversation

@Sg312
Copy link
Collaborator

@Sg312 Sg312 commented Mar 24, 2026

Summary

Fix quiver build

Type of Change

  • Bug fix

Testing

Manual

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Mar 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Mar 24, 2026 1:33am

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 24, 2026

Greptile Summary

This PR fixes a failing test in apps/sim/blocks/blocks.test.ts by adding 'file' to the list of valid input types and adding a type cast to Object.entries(block.inputs). The change makes the test consistent with blocks (e.g., quiver.ts, onedrive.ts, supabase.ts, slack.ts) that already legitimately use 'file' as an input type — the same type that was already accepted for block outputs in the adjacent test.

  • Adds 'file' to the validTypes array in the 'should have valid input types' test, matching what several existing block definitions use in their inputs config.
  • Adds as [string, { type: string }][] type assertion to Object.entries(block.inputs) to work around the fact that ParamType in types.ts does not include 'file', causing a type mismatch for any block that has type: 'file' inputs.
  • The root cause (the ParamType union missing 'file') is not addressed in this PR — updating ParamType would be the complete fix and would render the type cast unnecessary.

Confidence Score: 4/5

  • Safe to merge — minimal, well-scoped test fix with no production code changes.
  • The change is limited to a single test file and correctly aligns the input-type validation with what blocks already use in practice. The only follow-up is updating ParamType in types.ts to include 'file', which would remove the need for the type cast, but that's a non-blocking improvement.
  • No files require special attention beyond the noted ParamType inconsistency in apps/sim/blocks/types.ts.

Important Files Changed

Filename Overview
apps/sim/blocks/blocks.test.ts Adds 'file' to the valid input types list and applies a type cast to Object.entries to handle the mismatch between ParamType (which excludes 'file') and block inputs that legitimately use 'file'. Straightforward fix to make the test reflect reality.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["getAllBlocks()"] --> B["Iterate block.inputs"]
    B --> C{"inputConfig.type"}
    C -->|"'string' | 'number' | 'boolean' | 'json' | 'array'"| D["✅ Was already valid"]
    C -->|"'file'"| E["🔴 Previously failing assertion"]
    E --> F["PR: Add 'file' to validTypes"]
    F --> G["✅ Now passes"]
    H["ParamType in types.ts"] --> I["Still missing 'file'"]
    I --> J["Type cast added as workaround"]
Loading

Reviews (1): Last reviewed commit: "Fix test" | Re-trigger Greptile

@Sg312 Sg312 changed the title fix(mothership): test fix(quiver): build failed Mar 24, 2026
@Sg312 Sg312 changed the title fix(quiver): build failed fix(quiver): build fail Mar 24, 2026
@Sg312 Sg312 merged commit 5e53757 into staging Mar 24, 2026
11 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/mothership-test branch March 24, 2026 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant