Skip to content

feat: add c implementation for blas/base/dtrmv#7016

Open
ShabiShett07 wants to merge 24 commits intostdlib-js:developfrom
ShabiShett07:feature/c/dtrmv
Open

feat: add c implementation for blas/base/dtrmv#7016
ShabiShett07 wants to merge 24 commits intostdlib-js:developfrom
ShabiShett07:feature/c/dtrmv

Conversation

@ShabiShett07
Copy link
Contributor

@ShabiShett07 ShabiShett07 commented May 16, 2025

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: passed
  • task: lint_package_json status: passed
  • task: lint_repl_help status: na
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: na
  • task: lint_javascript_tests status: passed
  • task: lint_javascript_benchmarks status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: missing_dependencies
  • task: lint_c_examples status: missing_dependencies
  • task: lint_c_benchmarks status: missing_dependencies
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: na
  • task: lint_typescript_tests status: na
  • task: lint_license_headers status: passed ---

Progresses #2039.

Description

What is the purpose of this pull request?

This pull request:

  • Adds C implementation for the package blas/base/dtrmv

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@ShabiShett07
feat: add c implementation for blas/base/dtrmv
4cdad25 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels May 16, 2025
@ShabiShett07
Copy link
Contributor Author

ShabiShett07 commented May 16, 2025

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels May 16, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented May 16, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
blas/base/dtrmv $\color{green}718/718$
$\color{green}+100.00\%$ 		$\color{green}114/114$
$\color{green}+100.00\%$ 		$\color{green}5/5$
$\color{green}+100.00\%$ 		$\color{green}718/718$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@ShabiShett07 ShabiShett07 added GSoC Google Summer of Code. gsoc: 2025 Google Summer of Code (2025). labels May 23, 2025
@ShabiShett07
chore: update implementation
54a5c4e 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@ShabiShett07 ShabiShett07 marked this pull request as draft June 27, 2025 04:48
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jun 27, 2025
@ShabiShett07
chore: minor clean-up
af2a38e 
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
@ShabiShett07
chore: remove unused package
243b10a 
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
@ShabiShett07
Copy link
Contributor Author

ShabiShett07 commented Jun 30, 2025

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jun 30, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jun 30, 2025
@ShabiShett07
chore: minor clean-up
f94d43c 
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
@ShabiShett07
chore: minor clean-up
4c46c37 
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
@ShabiShett07
Copy link
Contributor Author

ShabiShett07 commented Jun 30, 2025

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jun 30, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jun 30, 2025
@ShabiShett07
chore: remove unused package
fe6deb9 
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
@ShabiShett07
chore: minor clean-up
5ca0392 
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
@ShabiShett07
chore: add correct variable
dc4574a 
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
@ShabiShett07
chore: minor clean-up
9e3723b 
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
@ShabiShett07
chore: minor clean-up
602fae7 
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
ShabiShett07 and others added 7 commits June 30, 2025 13:26
@ShabiShett07
chore: update markdown
4e8ace2 
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
@ShabiShett07
chore: update implementation
01de8bc 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@ShabiShett07
chore: update implementation
ee87bad 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@ShabiShett07
chore: minor clean-up
a40d428 
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
@ShabiShett07
chore: clean-up
45d1c4e 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@ShabiShett07
chore: minor clean-up
613dc97 
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
@ShabiShett07
chore: update variable name
8587b9e 
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
@ShabiShett07 ShabiShett07 mentioned this pull request Jul 4, 2025
Open
ShabiShett07
ShabiShett07 commented Jul 4, 2025
View reviewed changes
ShabiShett07
ShabiShett07 commented Jul 4, 2025
View reviewed changes
@ShabiShett07
chore: add appropriate comments for example
d17b829 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@ShabiShett07
chore: change comment
dfd24f4 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@ShabiShett07
chore: add proper indentation
573b3c8 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@ShabiShett07
fix: add appropriate package name
f98b52b 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@ShabiShett07 ShabiShett07 requested a review from kgryte July 4, 2025 10:56
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 4, 2025
@ShabiShett07 ShabiShett07 marked this pull request as ready for review July 5, 2025 04:30
dhruvan2006
dhruvan2006 reviewed Mar 8, 2026
View reviewed changes
Copy link
Contributor

@dhruvan2006 dhruvan2006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes that I think should be implemented. I hope the maintainers can provide a more thorough review.

lib/node_modules/@stdlib/blas/base/dtrmv/examples/c/example.c
const int N = 3;

// Perform the matrix-vector operations `x = A*x`:
c_dtrmv( CblasRowMajor, CblasUpper, CblasNoTrans, CblasUnit, N, A, N, x, 1 );
Copy link
Contributor

@dhruvan2006 dhruvan2006 Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe a more illustrative example would be to use CblasLower here because of the way matrix A is defined.

lib/node_modules/@stdlib/blas/base/dtrmv/examples/c/example.c
}

// Perform the matrix-vector operations `x = A*x` using alternative indexing semantics:
c_dtrmv_ndarray( CblasUpper, CblasNoTrans, CblasUnit, 3, A, 3, 1, 0, x, 1, 0 );
Copy link
Contributor

@dhruvan2006 dhruvan2006 Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

lib/node_modules/@stdlib/blas/base/dtrmv/lib/dtrmv.js
* @throws {TypeError} fourth argument must be a valid diagonal type
* @throws {RangeError} fifth argument must be a nonnegative integer
* @throws {RangeError} seventh argument must be greater than or equal to max(1,N)
* @throws {RangeError} seventh argument must be a valid stride
Copy link
Contributor

@dhruvan2006 dhruvan2006 Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary change

lib/node_modules/@stdlib/blas/base/dtrmv/src/dtrmv_ndarray.c

// Note on variable naming convention: sa#, ix#, i# where # corresponds to the loop number, with `0` being the innermost loop...

// Note on variable naming convention: sa#, ix#, i# where # corresponds to the loop number, with `0` being the innermost loop...
Copy link
Contributor

@dhruvan2006 dhruvan2006 Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate comment

lib/node_modules/@stdlib/blas/base/dtrmv/README.md
const int N = 3;

// Perform the matrix-vector operations `x = A*x`:
c_dtrmv( CblasRowMajor, CblasUpper, CblasNoTrans, CblasUnit, N, A, N, x, 1 );
Copy link
Contributor

@dhruvan2006 dhruvan2006 Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CblasLower

lib/node_modules/@stdlib/blas/base/dtrmv/README.md
}

// Perform the matrix-vector operations `x = A*x` using alternative indexing semantics:
c_dtrmv_ndarray( CblasUpper, CblasNoTrans, CblasUnit, 3, A, 3, 1, 0, x, 1, 0 );
Copy link
Contributor

@dhruvan2006 dhruvan2006 Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CblasLower

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte Awaiting requested review from kgryte

1 more reviewer

@dhruvan2006 dhruvan2006 dhruvan2006 left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). GSoC Google Summer of Code. gsoc: 2025 Google Summer of Code (2025). Needs Review A pull request which needs code review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShabiShett07 @stdlib-bot @dhruvan2006