fix: Missing audience validation in Keycloak authentication adapter (GHSA-48mh-j4p5-7j9v)

[mtrezza]

Pull Request

• Report security issues confidentially.
• Any contribution is under this license.

Issue

Missing audience validation in Keycloak authentication adapter (GHSA-48mh-j4p5-7j9v)

Tasks

• Add tests
• Add changes to documentation (guides, repository pages, code comments)
• Add security check
• Add new Parse Error codes to Parse JS SDK

Summary by CodeRabbit

• Refactor
  • Strengthened authentication security with improved verification mechanisms and enhanced cryptographic validation while maintaining compatibility with existing authentication flows.

[parse-github-assistant]

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement.

[parseplatformorg]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[coderabbitai]

📝 Walkthrough

Walkthrough

Keycloak authentication adapter refactored from userinfo HTTP-based verification to JWT-based verification using JWKS and RS256. Test suite updated to validate JWT cryptographic checks and claim validation instead of mocking external HTTP responses.

Changes

Cohort / File(s)	Summary
Keycloak Auth Adapter Implementation src/Adapters/Auth/keycloak.js	Replaces userinfo HTTP verification with JWKS-based JWT verification. Adds getKeycloakKeyByKeyId for JWKS key retrieval and verifyAccessToken for JWT validation with RS256 enforcement. Validates token claims (issuer, audience, subject, roles/groups) and updates error handling to reflect JWT validation failures. Public API signatures remain unchanged.
Authentication Adapter Test Suite spec/AuthenticationAdapters.spec.js	Restructures Keycloak auth adapter tests to validate JWT cryptographic verification instead of HTTP userinfo mocking. Adds comprehensive JWT validation scenarios including issuer validation, client-id/audience checks, subject verification, azp claims, roles/groups handling, and end-to-end RS256 signature verification. Updates error messages and assertions to align with JWT-based validation flow.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant KeycloakAdapter as Keycloak Adapter
    participant JWKS as JWKS Endpoint
    participant JWT as JWT Verifier

    Client->>KeycloakAdapter: validateAuthData(token)
    KeycloakAdapter->>KeycloakAdapter: Extract token header (kid)
    KeycloakAdapter->>JWKS: Retrieve JWKS (getKeycloakKeyByKeyId)
    JWKS-->>KeycloakAdapter: Return public key
    KeycloakAdapter->>JWT: Verify JWT with RS256<br/>(signature, iss, azp, sub)
    alt JWT Valid
        JWT-->>KeycloakAdapter: Token verified
        KeycloakAdapter->>KeycloakAdapter: Validate claims<br/>(roles, groups)
        KeycloakAdapter-->>Client: Authentication success
    else JWT Invalid
        JWT-->>KeycloakAdapter: Verification failed
        KeycloakAdapter-->>Client: Authentication error
    end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• fix: JWT Algorithm Confusion in Google Auth Adapter (GHSA-4q3h-vp4r-prv2) #10073 — Similar pattern of refactoring auth adapters from userinfo-based validation to JWKS/JWT verification with RS256 enforcement
• fix: JWT Algorithm Confusion in Google Auth Adapter (GHSA-4q3h-vp4r-prv2) #10072 — Related authentication adapter changes switching from HTTP userinfo validation to JWKS/JWT verification with matching test suite updates

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	The PR description addresses the security advisory but lacks implementation details and reasoning for the approach taken.	Add an Approach section explaining the JWT-based verification changes, why JWKS validation was introduced, and clarify which tasks were actually completed (tests appear added but documentation/security checks are unclear).

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The pull request title clearly identifies a security fix for missing audience validation in the Keycloak authentication adapter, with a specific security advisory reference.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.71%. Comparing base (93b784d) to head (aa06686).
⚠️ Report is 147 commits behind head on alpha.

Files with missing lines	Patch %	Lines
src/Adapters/Auth/keycloak.js	96.96%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##            alpha   #10137   +/-   ##
=======================================
  Coverage   92.71%   92.71%           
=======================================
  Files         192      192           
  Lines       16062    16083   +21     
  Branches      183      183           
=======================================
+ Hits        14892    14912   +20     
- Misses       1158     1159    +1     
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/Adapters/Auth/keycloak.js`:
- Around line 163-166: The current check always enforces roles/groups even when
authData.roles or authData.groups are undefined, causing valid tokens to be
rejected; update the logic in the function that reads jwtClaims, roles, groups
(use the symbols jwtClaims, roles, groups, and arraysEqual) to only compare
jwtClaims.roles to roles (and jwtClaims.groups to groups) when the corresponding
authData value was provided (i.e., if roles !== undefined then perform the
equality/arraysEqual check, same for groups). Also add a regression test that
sends a JWT containing roles/groups while authData only includes id +
access_token to ensure the token is accepted when roles/groups are omitted from
authData.
- Around line 117-121: Normalize and reuse Keycloak client-id handling: accept
and normalize any of config['client-id'], config.clientId, or config.resource
into a single local variable (e.g., clientId) and use that for the validation
that currently throws (the block around Parse.Error) and the azp check near the
later azp logic (around the code that compares azp to client id). Update the
JSDoc at the top and the second JSDoc (near lines 9 and 32 in this file) to
document that the adapter accepts client-id, clientId, or resource keys. Ensure
all references to the original config access (both the initial existence check
and the azp comparison) use the normalized clientId variable.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4ff43dd9-3350-41ac-a40e-9b2fecb12ce6

📥 Commits

Reviewing files that changed from the base of the PR and between da94750 and aa06686.

📒 Files selected for processing (2)

• spec/AuthenticationAdapters.spec.js
• src/Adapters/Auth/keycloak.js

[parseplatformorg]

🎉 This change has been released in version 9.5.2-alpha.5

[parseplatformorg]

🎉 This change has been released in version 9.6.0