feat: Add X-Content-Type-Options: nosniff header and customizable response headers for files via Parse.Cloud.afterFind(Parse.File)

[mtrezza]

Pull Request

• Report security issues confidentially.
• Any contribution is under this license.

Issue

Add X-Content-Type-Options: nosniff header and customizable response headers for file responses.

Tasks

• Add tests
• Add changes to documentation (guides, repository pages, code comments)
• Add security check
• Add new Parse Error codes to Parse JS SDK

Summary by CodeRabbit

• New Features

  • File response triggers (afterFind) can set or override HTTP response headers.
  • New forceDownload option to prompt file download.
  • X-Content-Type-Options: nosniff applied to file responses by default.

• Tests

  • Added tests for custom/overridden response headers in afterFind hooks.
  • Added tests ensuring nosniff is present for normal and ranged/streamed file responses.

• Documentation

  • Trigger request docs updated to include forceDownload and responseHeaders.

[parse-github-assistant]

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement.

[parseplatformorg]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds default X-Content-Type-Options: nosniff for streamed file responses and propagates a responseHeaders object (and forceDownload flag) through beforeFind/afterFind file triggers so hooks can modify HTTP response headers. Tests were added to verify header behavior.

Changes

Cohort / File(s)	Summary
Cloud Code tests spec/CloudCode.spec.js	Added two Parse.File afterFind tests exercising custom responseHeaders (set X-Custom-Header) and overriding/removing default X-Content-Type-Options.
Vulnerability tests spec/vulnerabilities.spec.js	Added tests asserting X-Content-Type-Options: nosniff is present for regular GET and Range (streaming) file responses.
Files router & trigger wiring src/Routers/FilesRouter.js, src/triggers.js	Introduce defaultResponseHeaders (X-Content-Type-Options: nosniff) for streamed responses; pass responseHeaders into beforeFind/afterFind and apply any trigger-provided responseHeaders (and forceDownload) to the outgoing response.
Cloud Code docs src/cloud-code/Parse.Cloud.js	Documented forceDownload and responseHeaders properties on Parse.Cloud.FileTriggerRequest (afterFind).

Sequence Diagram

sequenceDiagram
    participant Client as HTTP Client
    participant Router as FilesRouter
    participant Before as beforeFind Trigger
    participant After as afterFind Trigger
    participant Response as HTTP Response

    Client->>Router: GET /files/:id
    Router->>Router: set defaultResponseHeaders (X-Content-Type-Options: nosniff)
    Router->>Before: invoke beforeFind(request with responseHeaders)
    Before-->>Router: return (may modify responseHeaders)
    Router->>Router: stream or prepare file
    Router->>After: invoke afterFind(request with responseHeaders)
    After-->>Router: return (may modify responseHeaders, set forceDownload)
    Router->>Response: apply final responseHeaders and Content-Disposition
    Response-->>Client: file data + headers

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• fix: File metadata endpoint bypasses beforeFind / afterFind trigger authorization (GHSA-hwx8-q9cg-mqmc) #10106: Related changes around FilesRouter and file trigger behavior affecting file serving and trigger propagation of headers.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description check	✅ Passed	The pull request description follows the required template with Issue and Tasks sections completed. Tests and documentation updates are marked as done; security checks and Parse Error codes are appropriately marked as not applicable.
Title check	✅ Passed	The title accurately summarizes the main change: adding X-Content-Type-Options header security and customizable response headers for file responses via Parse.Cloud.afterFind.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@spec/CloudCode.spec.js`:
- Around line 4473-4487: The test currently allows Cloud Code afterFind to
delete the X-Content-Type-Options header via req.responseHeaders; change it so
the header is treated as non-overridable: keep the Parse.Cloud.afterFind handler
that attempts to delete req.responseHeaders['X-Content-Type-Options'] but update
the assertions to expect the header still exists (value 'nosniff') rather than
being undefined, and adjust any test description to state that afterFind cannot
remove this security header; reference the afterFind handler and
req.responseHeaders in your change.

In `@spec/vulnerabilities.spec.js`:
- Around line 862-890: The "(GHSA-3jmq-rrxf-gqrg) Stored XSS via file serving"
describe block is incorrectly nested inside the "(GHSA-mf3j-86qx-cq5j) ReDoS via
LiveQuery subscription" describe; move the entire describe block starting with
describe('(GHSA-3jmq-rrxf-gqrg) Stored XSS via file serving', ...) out so it is
a sibling of the ReDoS describe by relocating its closing `});` so the ReDoS
describe (the block beginning with describe('(GHSA-mf3j-86qx-cq5j) ReDoS via
LiveQuery subscription', ...)) is closed before the Stored XSS describe begins,
ensuring both describe blocks are at the same level.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 864cccff-9089-4f61-a345-9d3af74bd1bd

📥 Commits

Reviewing files that changed from the base of the PR and between 510b898 and 2053572.

📒 Files selected for processing (5)

• spec/CloudCode.spec.js
• spec/vulnerabilities.spec.js
• src/Routers/FilesRouter.js
• src/cloud-code/Parse.Cloud.js
• src/triggers.js

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.58%. Comparing base (416cfbc) to head (471957a).
⚠️ Report is 127 commits behind head on alpha.

Additional details and impacted files

@@           Coverage Diff           @@
##            alpha   #10158   +/-   ##
=======================================
  Coverage   92.57%   92.58%           
=======================================
  Files         192      192           
  Lines       16199    16207    +8     
  Branches      183      183           
=======================================
+ Hits        14997    15005    +8     
  Misses       1190     1190           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@spec/vulnerabilities.spec.js`:
- Around line 864-889: The tests inside the describe block are over-indented by
two spaces; reformat the block so each it(...) line and its inner lines use the
correct 2-space indentation instead of 4 (adjust the indentation for the two
tests that create new Parse.File, call file.save({ useMasterKey: true }), call
request({...}) with headers including 'X-Parse-Application-Id' and
'X-Parse-REST-API-Key' (and 'Range' for the streaming test), and the expect(...)
assertions) — reduce each inner line by two spaces so the it blocks align with
the describe's expected indentation.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7a7de221-769a-44e5-a7f8-32dd61361b96

📥 Commits

Reviewing files that changed from the base of the PR and between 2053572 and 9109fcb.

📒 Files selected for processing (1)

• spec/vulnerabilities.spec.js

[parseplatformorg]

🎉 This change has been released in version 9.6.0-alpha.1

[parseplatformorg]

🎉 This change has been released in version 9.6.0